Re: [reSIProcate] Fast streams encode std::endl incorrectly on *nix systems
Might be worth skimming to make sure nothing had been counting on that
\r\n when encoding things into a SIP message.
(where /r/n is used as the line terminator regardless of platform).
RjS
On Dec 1, 2008, at 7:35 PM, Justin Matthews wrote:
Done. Let me know if you have issues.
Thanks,
-justin
-----Original Message-----
From: Byron Campen [mailto:bcampen@xxxxxxxxxxxx]
Sent: Monday, December 01, 2008 8:28 PM
To: Justin Matthews
Cc: 'resiprocate-devel@xxxxxxxxxxxxxx'
Subject: Re: [reSIProcate] Fast streams encode std::endl incorrectly
on *nix
systems
Ok, fine by me!
Best regards,
Byron Campen
I think we can change this to '\n' for all platforms, Visual C++
actually
uses '\n' for its STL implementation. Not sure why "\r\n" was
picked :-).
Thanks,
-justin
-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of
Byron Campen
Sent: Monday, December 01, 2008 8:01 PM
To: resiprocate-devel@xxxxxxxxxxxxxx
Subject: [reSIProcate] Fast streams encode std::endl incorrectly on
*nix
systems
On *nix systems, std::endl is encoded as '\n', but the following
code in resipfaststreams.hxx encodes it as "\r\n"
*snip*
if (_Pfn == static_cast<std::ostream& (*)
(std::ostream&)>(std::endl))
{
if (buf_->writebuf("\r\n",2) < 2)
{
good_ = false;
}
}
*snip*
Is there going to be an easy way to make this behavior consistent
with whatever the platform does? Just using an #ifdef WIN32 won't
get this
quite right, but it may be good enough for us. Thoughts?
Best regards,
Byron Campen
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel