Re: [reSIProcate] Timers: why system time?

["Alexander Altshuler" <alt@xxxxxxxxx>]

Hi All

Timer::getTimeMs() is called from BaseTimerQueue::msTillNextTimer() 

So IMHO it will be often called independent from existing timers.

Regards
Alexander Altshuler
Xeepe team

-----Original Message-----
From: Adam Roach [mailto:adam@xxxxxxxxxxx] 
Sent: Thursday, October 30, 2008 6:27 PM
To: Alexander
Cc: 'resiprocate-devel'
Subject: Re: [reSIProcate] Timers: why system time?

Scott (and any other Windows developers on the list):

The Windows 49.7-day rollover fix in this patch uses heuristics to 
handle the rollover in an efficient manner -- you can actually lose 
timers if you have relatively low timer activity and a multi-minute 
timer running when the tick count rolls over.  The chances of this 
happening are, admittedly, vanishingly small (especially in normal SIP 
usage). In any case, you might want to give that code a quick review to 
ensure that you're comfortable with it.

Also, I think it's safe to say that it's difficult to test the 
correctness of the code, as step one of any such test plan necessarily 
involves something like: "boot a Windows machine and wait 49.6 days." 
Make sure you're comfortable with that fact as well.