< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] Timer's Id thread safety


I good with the removal of mTimerCount - is anyone using this in their
own applications?

Scott

-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of
Alexander
Sent: Wednesday, October 29, 2008 8:03 AM
To: resiprocate-devel@xxxxxxxxxxxxxxxxxxxx
Subject: [reSIProcate] Timer's Id thread safety

Hi

While working on monotonic clock patch I have found next issue:
Class Timer has a static member mTimerCount which is used for generating
"unique" timer id.
But timers are created (and mTimerCount accessed and incremented) from
some possibly different threads: stack, dum, app.
So this counter must be implemented as atomic or mutex protected value. 

I analyzed reSIProcate's source codes and it looks like timer id feature
is never used.
My offer is to remove it at all.

Regards
Alexander Altshuler
Xeepe team
http://xeepe.com



_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel