Re: [reSIProcate] InviteSession::getRemoteSdp() does not always returnlatest sdp

[Björn Andersson <bjorn.andersson@xxxxxxxxxx>]

Scott,
It turned out the patch wasn't complete, sdp is an auto_ptr and it is 
cleared by the assignment to mCurrentRemoteSdp.
Next line should be changed to:
    handler->onAnswer(getSessionHandle(), msg, *mCurrentRemoteSdp);

Best Regards
Björn A.



Scott Godin wrote:
> Nice catch - thanks.  I've committed the fix to main.
>
> Scott
>
> -----Original Message-----
> From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx 
> [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of Björn Andersson
> Sent: Monday, June 16, 2008 8:59 AM
> To: resiprocate-devel@xxxxxxxxxxxxxx
> Subject: [reSIProcate] InviteSession::getRemoteSdp() does not always 
> returnlatest sdp
>
> 200 Ok after a re-invite does not update mCurrentRemoteSdp of InviteSession, 
> see patch.
>
> best regards
> Björn Andersson
>
>
> --
> This communication is confidential and intended solely for the addressee(s). 
> Any unauthorized review, use, disclosure or distribution is prohibited. If you 
> believe this message has been sent to you in error, please notify the sender by 
> replying to this transmission and delete the message without disclosing it. 
> Thank you.
> E-mail including attachments is susceptible to data corruption, interruption, 
> unauthorized amendment, tampering and viruses, and we only send and receive 
> e-mails on the basis that we are not liable for any such corruption, 
> interception, amendment, tampering or viruses or any consequences thereof.
>
>
> ---------------------------------------------------------------------------
> This email communication may contain CONFIDENTIAL, PRIVILEGED and/or
> LEGALLY PROTECTED information and is intended only for the named
> recipient(s). Any unauthorized use, dissemination, copying or forwarding
> is strictly prohibited. If you are not the intended recipient and have 
> received this email communication in error, please notify the sender 
> immediately, delete it and destroy all copies of this email.
> ---------------------------------------------------------------------------
>
>
>   

--
This communication is confidential and intended solely for the addressee(s). 
Any unauthorized review, use, disclosure or distribution is prohibited. If you 
believe this message has been sent to you in error, please notify the sender by 
replying to this transmission and delete the message without disclosing it. 
Thank you.
E-mail including attachments is susceptible to data corruption, interruption, 
unauthorized amendment, tampering and viruses, and we only send and receive 
e-mails on the basis that we are not liable for any such corruption, 
interception, amendment, tampering or viruses or any consequences thereof.