Re: [reSIProcate] The ThreadIf bug?

["Scott Godin" <slgodin@xxxxxxxxxxxx>]

Calling detach without ever having called run is a bit odd – but it’s still a good idea to initialize this member – I’ll commit a fix to SVN.  Thanks.

 

From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of Karlsson
Sent: Saturday, January 26, 2008 8:06 AM
To: resiprocate-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [reSIProcate] The ThreadIf bug?

 

I think the Thread::ThreadIf() should be:

ThreadIf::ThreadIf() : mId(0), mShutdown(false), mShutdownMutex(), mThread(NULL)
{

}
 

Thanks 

 

2008/1/26, Karlsson <boost.regex@xxxxxxxxx>:

I saw the ThreadIf  in reSIProcate 1.2.2,

 

ThreadIf::ThreadIf() : mId(0), mShutdown(false), mShutdownMutex()
{
}
 

 

There do not  initialize the mThread, so if in this case will get application crash:

 

#include <WinSock2.h>
#include <Windows.h>
#include <string>
using namespace std;

#include <rutil/threadif.hxx>
using namespace resip;

#pragma comment(lib, "ws2_32.lib")
#pragma comment(lib, "../lib/rutilD.lib")

 

class MyThread : public ThreadIf
{
public:
 virtual void thread()
 {
  cout << "MyThread::thead()" << endl;
 }
};

class Test
{
public:

 void release()
 {
  mMyThread.detach();
 }

protected:

private:

 MyThread mMyThread;
};

 

int main()
{
 Test t;

  t.release();

 return 0;
}