< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] Potential bug in tfm/TestUser.cxx


Hi,

Thanks for your quick reply.

My problem is that I was trying to initialize it with a different
password, and the constructor's API is confusing since it takes a
password value which doesn't seem to be used at all.

By looking at the makeReproUser(...) function in Fixture.cxx, it is calling:

return new TestReproUser(proxy, j, j.user(), j.user(), ...)

The 4th parameter to TestReproUser(...) gets passed in as the third
parameter of its parent class, TestUser. That parameter is the
password parameter of the TestUser class, meaning that
makeReproUser(...) seems to be doing the correct thing of setting the
same value for the username and the password.

If this is right, then changing the initialization of
TestUser::mPassword so that it uses password instead of authName
shouldn't impact the tests since the tests seem to be using the
correct API.

I didn't run the sanityTest yet, let me know what you think.

Regards,
Francis

On Jan 21, 2008 11:23 AM, Jason Fischl <jason@xxxxxxxxxxxxxxx> wrote:
> This is actually correct. For a test user we use the simple rule of
> making the password the same as the authName. Keep in mind that the
> TestUser also is responsible for provisioning the user into the proxy.
> (repro in this case)
>
>
> On Jan 21, 2008 8:02 AM, Francis Joanis <francis.joanis@xxxxxxxxx> wrote:
> > Hi all,
> >
> > While building a test using the TFM library, I realized that the
> > initialization of the TestUser class puts the authName passed-in value
> > into the mPassword member. I think it's a typo (it should be password)
> > and I just wanted to let you know about it.
> >
> > Tell me if it makes sense.
> >
> > Regards,
> > Francis Joanis
> > _______________________________________________
> > resiprocate-devel mailing list
> > resiprocate-devel@xxxxxxxxxxxxxxx
> > https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
> >
>