< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] ACK retransmission


Another great catch!  I will commit this fix.  Thanks.

Byron - this fix should be put into 1.2.1 release.

Scott

-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of Boris
Rozinov
Sent: November 25, 2007 2:33 PM
To: resiprocate-devel@xxxxxxxxxxxxxxx
Subject: [reSIProcate] ACK retransmission


InviteSession::dispatch checks whether ACK should be
retransmitted by looking at mAcks with transaction ID
retrieved from incoming 200OK. But
InviteSession::sendAck adds new entry to mAcks using
transaction id retrieved from ACK message that is
going to be sent. ACK is separated transaction and its
ID is different from transaction ID of Invite
transaction. Therefore the following to lines should
be fixed to:

mAcks[source->getTransactionId()]=ack;
mDum.addTimerMs(DumTimeout::CanDiscardAck, Timer::TH,
getBaseHandle(),
ack->header(h_CSeq).sequence(),0,source->getTransactionId());

Thanks,
Boris



      Ask a question on any topic and get answers from real people. Go to
Yahoo! Answers and share what you know at http://ca.answers.yahoo.com
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel