< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index Next in Thread >

Re: [reSIProcate] [reSIProcate-commit] resiprocate 7261 bcampen: Have LazyParser::isWellFormed catch all exception types.


If we can guarantee that all parsing exceptions will be of a common class (or a small number of classes), I am all for this. However, I discovered lately that there is at least one additional exception that is thrown by some of the parameter classes (ParseException). For the time being, I have clamped down completely. If we could move ParseException.hxx to rutil, and derive ParseBuffer::Exception from it (or just have ParseBuffer throw a plain-old ParseException), we'd (hopefully) be back to having a single exception class to serve our parse-failure needs.

Best regards,
Byron Campen

I'm not sure that I agree with this particular change. isWellFormed should only catch parse exceptions. Any other exception can't be handled in this context and should be passed up. Is there a specific situation that you are trying to guard against here?

On 9/25/07, svn@xxxxxxxxxxxxxxx <svn@xxxxxxxxxxxxxxx> wrote:
Projectresiprocate
New Revision7261
Committerbcampen (Byron Campen)
Date2007-09-25 09:53:49 -0500 (Tue, 25 Sep 2007)

Log

 Have LazyParser::isWellFormed catch all exception types.



Modified:


_______________________________________________
resiprocate-commit mailing list
resiprocate-commit@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-commit

_______________________________________________
resiprocate-devel mailing list