reSIProcate

Mailing Lists

Source Code

Google Search:



< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] in ResponseContext::beginClientTransaction

That would be a typo. Let me fix that.

Best regards,
Byron Campen

Hi repro,

         In ResponseContext::beginClientTransaction,  ResponseContext.cxx   line 523, latest version.

rt.uri().scheme() == request.header(h_Routes).front().uri().scheme();

 

why it’s “==”, not “=”,  thanks for answer.

 

/hongsion

 

发件人: hongsion [mailto:hongsion@xxxxxxxxx]
发送时间: 2006年12月1日 9:32
收件人: 'Scott Godin'; 'resiprocate-devel@xxxxxxxxxxxxxxxxxxxx'
主题: 答复: [reSIProcate] HttpConnection::tryParse()

 

         You are right, HttpConnection will be destroyed immediately after TxBuffer finish sending. And actually RxBuffer will receive very little size data each time, so it’s safe here. Thanks!

 

发件人: Scott Godin [mailto:slgodin@xxxxxxxxxxxx]
发送时间: 2006年11月30日 22:55
收件人: hongsion; resiprocate-devel@xxxxxxxxxxxxxxxxxxxx
主题: RE: [reSIProcate] HttpConnection::tryParse()

 

HttpConnections are destroyed immediately after receiving data, then sending the response.  The RxBuffer is destroyed at this time.  Are you seeing any issues with this?

 

From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of hongsion
Sent: Wednesday, November 29, 2006 3:29 AM
To: resiprocate-devel@xxxxxxxxxxxxxxxxxxxx
Subject: [reSIProcate] HttpConnection::tryParse()

 

Hi resip,

         I found in HttpConnection::tryParse(), “mRxBuffer” will be enlarged unlimitedly, for there is no substr process like mTxBuffer. Is it? Please check!

 

Regards,

hongsion

 

发件人: hongsion [mailto:hongsion@xxxxxxxxx]
发送时间: 2006年11月24日 15:57
收件人: 'resiprocate-devel@xxxxxxxxxxxxxxxxxxxx'
主题: suggestion!

 

Hi resip,

         I found ServerRegistration::dispatch(),mOriginalContacts variable is not used. And stack will update database for each contact. My advice is stack should update mOriginalContacts, and after all contacts are updated, write mOriginalContacts back to database. this way maybe more efficient. Not sure is it right or not, Welcome comments.

 

 

Regards,

hongsion

_______________________________________________
resiprocate-devel mailing list