< Previous by Date Date Index Next by Date >
  Thread Index  

[reSIProcate] resiprocate build warnings


hi

I am getting some warnings when building resiprocate from svn r6799:
(g++ (GCC) 4.1.2 20060901 (prerelease) (Debian 4.1.1-13))


MsgHeaderScanner.cxx: In member function ‘resip::MsgHeaderScanner::ScanChunkResult 
resip::MsgHeaderScanner::scanChunk(char*, unsigned int, char**)’:
MsgHeaderScanner.cxx:945: warning: array subscript has type ‘char’
tassert.h:40: warning: ‘tassert_stack_ptr’ defined but not used
tassert.h:42: warning: ‘tassert_ncases’ defined but not used
testParserCategories.cxx:1860: warning: this decimal constant is unsigned only 
in ISO C90
testParserCategories.cxx:1883: warning: this decimal constant is unsigned only 
in ISO C90
testParserCategories.cxx:1884: warning: this decimal constant is unsigned only 
in ISO C90
testSdp.cxx: In function ‘int main(int, char**)’:
testSdp.cxx:59: warning: unused variable ‘codecs’
tassert.h: At global scope:
tassert.h:40: warning: ‘tassert_stack_ptr’ defined but not used
../../../build/../resip/stack/test/tassert.h:40: warning: ‘tassert_stack_ptr’ 
defined but not used
testSipMessage.cxx: In function ‘int main(int, char**)’:
testSipMessage.cxx:232: warning: value computed is not used


not sure about what this line is supposed to do:

testSipMessage.cxx:232

         message1->header(h_StatusLine).statusCode() == 407;




this patch should fix some of them:

Index: resip/stack/MsgHeaderScanner.cxx
===================================================================
--- resip/stack/MsgHeaderScanner.cxx    (revision 6799)
+++ resip/stack/MsgHeaderScanner.cxx    (working copy)
@@ -37,7 +37,7 @@
    ccLineFeed,
    numCharCategories
 };
-typedef char CharCategory;
+typedef uint8_t CharCategory;

 char*
 MsgHeaderScanner::allocateBuffer(int size)
Index: resip/stack/test/testSdp.cxx
===================================================================
--- resip/stack/test/testSdp.cxx        (revision 6799)
+++ resip/stack/test/testSdp.cxx        (working copy)
@@ -57,6 +57,7 @@
        for (std::list<resip::SdpContents::Session::Medium>::const_iterator i = 
sdp.session().media().begin(); i !=
sdp.session().media().end(); i++)
        {
           const std::list<resip::SdpContents::Session::Codec> &codecs = 
i->codecs();
+         (void)codecs;
        }

        //assert(sdp.session.getAttributes().count == 2);