< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] Pidf, TFM and test code


Derek MacDonald wrote:

I’ve just hit another example of why we should deprecate Pidf. Some dependencies have crept into tfm which cause tfm not to be built if Pidf was not included in stack. As any app that wants to do rpid cannot link Pidf in, this requires patching tfm not rely on Pidf.

Also, the new multi-part tests in resip/stack/test depend on Pidf. Tfm was easy to fix this time, as NotifyContents does not appear to be used in sanityTests, but the multipart test will be more work.

So, I think we should:

   1. deprecate Pidf and not use in our codebase; remove it from our
      Makefiles.
   2. have Pidf in the Makefile be a configure option, but do **not**
      use Pidf in any other files.

I lean towards option 1.


That's a reasonable long-term plan; however, I'd prefer not give people a nasty surprise just because they missed this on the list. I would propose doing #2 at first -- that way, anyone who feels pain from the removal can have a quick recovery route (and will probably scream so that we can have a conversation about what they're doing). If no one speaks up in the six months after making it a configurable option (off by default), then pull it out altogether (that is, put it in the "deprecated" directory).

/a