Re: [reSIProcate] A couple more minor issues from torture-tests

["Scott Godin" <slgodin@xxxxxxxxxxxx>]

Hi Byron,

I've been away for the last week - so I'm just catching on emails now!
Thanks for all your work on this stuff.

For problem 1  - I saw your commit.  You should be checking the scheme
against the profile setting, instead of hard coding sip and sips.  For
example the following code is from validateRequestURI in
DialogUsageManager.cxx 

   // RFC3261 - 8.2.2
   if
(!getMasterProfile()->isSchemeSupported(request.header(h_RequestLine).ur
i().scheme()))
   {
      InfoLog (<< "Received an unsupported scheme: " <<
request.brief());
      SipMessage failure;
      makeResponse(failure, request, 416);
      sendResponse(failure);

          return false;
   }

> -----Original Message-----
> From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
> Byron Campen
> Sent: Tuesday, August 08, 2006 11:19 AM
> To: resiprocate-devel
> Subject: [reSIProcate] A couple more minor issues from torture-tests
> 
> 1. Currently ServerRegistration succeeds when the aor has a scheme
> other than sip or sips. This is a pretty easy fix (in
> ServerRegistration::dispatch, we check the scheme, and send a 400 if
it
> isn't correct).
> 
> 2. Currently, the authentication functions in Helper do not check
> whether the authentication scheme is "Digest" (they assume that
> "Digest" is being used without verifying whether this is true). This
is
> also easily fixed.
> 
> Unless anyone has objections, I will be applying fixes for these to
the
> main trunk.
> 
> Best regards,
> Byron Campen