Re: [reSIProcate] Added new make check target & scripts to run tests

[Bob Bramwell <bob@xxxxxxxxxx>]

Thank your for doing this!  It gives everyone a much clearer idea of what tests 
are presumed to be valid and up-to-date.  However, let me point out that your 
script calls "die" any time a test exits with a failure status, which makes 
redundant the code that reports other failures and tallies up the failure count.

While I'm at it, since I don't have modify permission on any of this stuff, 
there is a problem in testConnectionBase.  If the minChunkSize gets set to 0 the 
read function will assert because it believes there is nothing to read.  The fix 
is left as an exercise for the reader :-)

Cheers,
        Bob.

Derek MacDonald wrote:
> Chris  & I added a runtest.sh script to resip/stack/test and rutil/test
> which runs all known good tests and checks the exit code of each to see if
> the test passed.  The output of each test is written to <testname>.log. 
>
>  
>
> I added a makefile target, check, to main/Makefile which will run both these
> scripts.  The script itself returns a non-zero exit code if any of the tests
> fail, so make check will fail if a any test fails.
>
>  
>
> Not all tests are in the scripts; we need to clean up or remove existing
> tests and add them.  Please add new tests to the scripts when you write
> them.  I haven't tried yet, but the scripts should run under cygwin or
> another bash shell installed on windows(make check won't work).  
>
>  
>
> So, in summary, running "make check "before checking in highly encouraged,
> and it provides an easy way to run test on the stack after checkout.
>
>  
>
> --Derek
>
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel

--
Bob Bramwell            Ditech Communications (Canada) | This space
Ph: 403 269 2938 x155   #310 602 11th Ave SW           | intentionally
FX: 403 269 2993        Calgary, AB, T2R 1J8           | left blank.