< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

RE: [reSIProcate] memory leak on ServerPublication.


I already fixed this issue in SVN head a few weeks back.

 


From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Derek MacDonald
Sent: Friday, November 25, 2005 4:55 AM
To: noiile@xxxxxxxxxxx; 'resiprocate-devel'
Subject: RE: [reSIProcate] memory leak on ServerPublication.

 

That should probably be reset, not release…I'll look into it.

 

Thanks,

 

Derek

 

CONFIDENTIALITY NOTICE

This email and any files transmitted with it contains proprietary information and, unless expressly stated otherwise, all contents and attachments are confidential. This email is intended for the addressee(s) only and access by anyone else is unauthorized. If you are not an addressee, any disclosure, distribution, printing or copying of the contents of this email or its attachments, or any action taken in reliance on it, is unauthorized and may be unlawful. If you are not an addressee, please inform the sender immediately and then delete this email and any copies of it. Thank you for your co-operation.


From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Noiile
Sent: Thursday, November 24, 2005 8:57 PM
To: resiprocate-devel
Subject: [reSIProcate] memory leak on ServerPublication.

 

resiprocate-devel, Hello

 

In code ServerPublication::updateMatchingSubscriptions(), ServerPublication release the ownership of mLastBody.mContents and  mLastBody.mAttributes.

I don't understand why do it like this, and I found that it will result in memory leaks because no one will delete object mContents and mAttributes, ServerPublication lost the ownership of them.

 

ServerPublication::updateMatchingSubscriptions()

{

   ........

   //Noiile:MEMORY LEAKS!!!

   //mLastBody.mContents.release(); 
   //mLastBody.mAttributes.release();

}

 

2005-11-25