RE: [reSIProcate] onSuccess for registration is called only ones
I agree - if the user explicitly requests a refresh, then there should be a
callback. If the refresh is automatic, then there should NOT be a callback.
Scott
-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Gianluca
Martiniello
Sent: Thursday, November 10, 2005 6:17 AM
To: Asheesh Joshi
Cc: resiprocate-devel@xxxxxxxxxxxxxxxxxxx; Sasha Youkhananov
Subject: Re: [reSIProcate] onSuccess for registration is called only ones
Asheesh Joshi wrote:
> Its not a bug. Its an intended behavior. Why would you need
> a call back for Registration "Refresh" ? The stack automatically
> refreshes the Registration for you and keeps doing it unless you
> de-Register. This is as per RFC 3261 and is perfectly ok.
> Yes, if you do need to customize for your UA for every
> registration refresh, you will need to add the code you have stated. But
> I don't think that should be a general solution to be submitted in the
> stack.
But if an application using dum explicitly requests a registration
refresh with the requestRefresh() method of the class
ClientRegistration maybe it would like to be notified about the outcome
of the refresh procedure... otherwise why should requestRefresh() method
exist?
> -----Original Message-----
> *From:* resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx]*On Behalf Of
> *Sasha Youkhananov
> *Sent:* Thursday, November 10, 2005 4:21 PM
> *To:* resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> *Subject:* [reSIProcate] onSuccess for registration is called only ones
>
>
>
> Hello resiprocate developers.
>
>
>
> According to comments inside RegistrationHandler.hxx onSuccess () is
> supposed to be called each time when registration succeeds.
>
> Unfortunately, it doesn't happen.
>
> The callback above is called only ones when my client registers for the
> first time. When the dum repeats registration on behalf of my client
> automatically, I don't get onSuccess notifications.
>
> Moreover, I don't get this notification too even registration succeeds
> after any failure.
>
> By the way, the onFailure call-back is called each time a failure
occurred.
>
>
>
> I think it would be correct to add the following code to
>
> ClientRegistration::dispatch(...) in ClientRegistration.cxx:
>
>
>
> From line 320:
>
>
>
> case Registered:
>
> case Refreshing:
>
> mState = Registered;
>
> //* the line below should be added to solve the problem
>
> mDum.mClientRegistrationHandler->onSuccess (getHandle (), msg);
>
> break;
>
>
>
> Can anybody from you be so kind to confirm this fix?
>
>
>
> Best Regards,
>
> //Sasha//
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxxxxxx
https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel