RE: [reSIProcate] InviteSession::isEarly bug

["Scott Godin" <slgodin@xxxxxxxxxxxx>]

Hi Jason,

Assuming the definition of "Early" is from first dialog creating 1xx (sent
or received, depending on UAS or UAC side) until final response.

I think you are missing the following states:
UAC_SentAnswer - after sending PRACK answer - still waiting for 200
UAS_EarlyProvidedOffer - this is after 1xx is sent
UAS_FirstSentOfferReliable - this is after 1xx is sent

Also the following should likely be removed:
UAC_SentUpdateConnected - this is after receiving a 200I
UAC_Start - this is before receiving a 1xx
UAS_Start - this is before sending a 1xx
UAS_Offer - this is before sending a 1xx
UAS_OfferProvidedAnswer - this is before sending a 1xx

Scott

-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Jason
Fischl
Sent: Saturday, September 24, 2005 7:09 PM
To: resiprocate
Subject: [reSIProcate] InviteSession::isEarly bug

Hi all,

Can folks take a look at InviteSession::isEarly and review it to see
if we've got all of the states identified correctly.

bool
InviteSession::isEarly() const
{
   switch (mState)
   {
      case UAC_Start:
      case UAC_Early:
      case UAC_EarlyWithOffer:
      case UAC_EarlyWithAnswer:

         //case UAC_Answered:
         //case UAC_Terminated:
      case UAC_SentUpdateEarly:
      case UAC_SentUpdateConnected:
      case UAC_ReceivedUpdateEarly:
         //case UAC_SentAnswer:
      case UAC_QueuedUpdate:

      case UAS_Start:
      case UAS_Offer:
      case UAS_OfferProvidedAnswer:
      case UAS_EarlyOffer:
      case UAS_EarlyProvidedAnswer:
      case UAS_EarlyNoOffer:
      case UAS_FirstEarlyReliable:
      case UAS_EarlyReliable:
         return true;

      default:
         return false;
   }
}


Jason
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxxxxxx
https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel