Re: [reSIProcate] mExpires is not set

["Noiile" <noiile@xxxxxxxxxxx>]

Noiile, Hello

 

The same of ServerPublication.mDocumentKey. It never be used, is it unnecessary?

 

Noiile, noiile@xxxxxxxxxxx

2005-9-21

----- Receiving the following content -----

Receiver: Noiile

Receiver: resiprocate-devel

Time: 2005-09-21, 13:03:42

Subject: [reSIProcate] mExpires is not set

resiprocate-devel, Hello

 

When UAS receviced the first PUBLISH, it will create a new ServerPublication and call onInitial() handler.

But I found that mExpires which pass to function onInitial() was not set value, and it was not be initialized too.

Maybe it is a bug.

 

In function :

ServerPublication::dispatch(const SipMessage& msg)

{

   assert(msg.isRequest());
   ServerPublicationHandler* handler = mDum.getServerPublicationHandler(mEventType);
   mLastRequest = msg;

   /***********************************************

   //I think Some codes should be added as following

   mExpires = 3600; 
   if (msg.exists(h_Expires))
   {
      mExpires = msg.header(h_Expires).value();
   }

    ************************************************/
  

   if (msg.exists(h_SIPIfMatch))
   else
   {
      mLastBody = Helper::extractFromPkcs7(msg, *mDum.getSecurity());
      handler->onInitial(getHandle(), mEtag, msg,
                         mLastBody.mContents.get(),
                         mLastBody.mAttributes.get(),
                         mExpires); //***************** mExpires was not be initialized
   }
}

 

Noiile, noiile@xxxxxxxxxxx

2005-9-21