| < Previous by Date | Date Index | Next by Date > |
| < Previous in Thread | Thread Index | Next in Thread > |
|
This is great stuff Micky! I’ll
review your .dot file comments and update the SVN copy appropriately. I’ve attached a PDF copy of your
Visio diagrams for people (without Visio) to see – they are great.
I think they should be added to SVN dum\doc after the state errors are fixed. Scott From: Micky Kaufmann
[mailto:micky@xxxxxxxxxxx] Hi All, I’ve attached an RTF file containing differences
between the source code and the file ‘dum-clientinvite-state.dot’. You can see in the attached file that in some transitions the
description of what to do is missing a few methods or a method was added to it. For example: some transitions from the start event are
missing the ‘app::onNewSession’ method, but there’s a
transition from Early to EarlyWithOffer that contains ‘app::onNewSession’
even though it seems an error. In some cases the event causes a transition from one event
to another when the second state seems wrong! Some transitions are missing and I couldn’t find some
of the transitions in the source code. Since I’m not always sure if the fix for an error
should be in the source code or in the state machine (like in the
‘app::onNewSession’ example) I’m posting it to this
newsgroup… For now I only reviewed the client state machine and since
I’m pretty sure the document I’m sending will solve some bugs
I’ll continue to review the other invite state machines. By the way I also attached the draft drawings of the state
machines – all in one visio file. Regards, Micky |
Attachment:
Visio-dum-fsms1.pdf
Description: Adobe PDF document