[reSIProcate] Minor point: passing shared pointers
There are fair number of places in the code where SharedPtrs are being
passed by reference, when actually const reference would be more
appropriate. For example DialogUsageManager.hxx has
void setMasterProfile(SharedPtr<MasterProfile>& masterProfile);
instead of
void setMasterProfile(SharedPtr<MasterProfile> const & masterProfile);
(You aren't going to modify my copy of the SharedPtr, only make your own copy of it.)
I came across this because I tend to make absolutely everything I can
const - and if I have a const SharedPtr I can't pass it to one of these
functions.
- Alan