Re: [reSIProcate] ServerInviteSession::accept() vs re-INVITE

[Dmitry Semyonov <dsemyonov@xxxxxxx>]

On Fri, 10 Jun 2005, Dmitry Semyonov wrote:

> There is the following comment inside ServerInviteSession class:
> 
> /** accept a re-invite, etc.  Always 200? this is only applicable to the UAS 
> */
> virtual void accept(int statusCode=200);
> 
> But it seems accept() must not be called for re-invites. (At least 
> after provideAnswer()). Otherwise DUM (debug) will assert inside 
> the function due to unhandled mState == Connected. It seems 
> provideAnswer() alone is enough.
> 
> If my understanding is correct, could somebody update the misleading 
> comment? TIA

At the same time accept() is required for incoming calls after 
provideAnswer(). This is totally inconsistent! One more misleading 
comment:

/** Called to set the answer that will be used in the next messages that
    sends an offer. Does not send an answer */
                    ~~~~~~~~~~~~~
virtual void provideAnswer(const SdpContents& answer);

But it _sends_ in case of re-INVITE!

So, probably the code should be updated to match the comments instead.

-- 
...Bye..Dmitry.