< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] DUM forgets to #include SipMessage.hxx


Dialog.hxx doesn't need the #include since it is only used as a
reference in the include file. The .cxx needs the include though.

Jason


On 4/14/05, Scott Godin <slgodin@xxxxxxxxxxxx> wrote:
> I'll commit the include fix for Dialog.hxx when SVN comes back up - (oddly
> enough this doesn't generate an error on VS.NET 7.1).
> 
> For the DialogUsageManager.hxx problem - the head revision does not include
> this constructor anywhere.  You must be using an older version that had
> issues.
> 
> Also (from your last email) - you are right the dum_7_0.vcproj file is
> missing - I'll commit one later too.
> 
> -----Original Message-----
> From: Anthony Harris [mailto:slightlydisturbed@xxxxxxxxxxx]
> Sent: Thursday, April 14, 2005 6:08 AM
> To: resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [reSIProcate] DUM forgets to #include SipMessage.hxx
> 
> I think I've fixed the compile problem. In the DUM file Dialog.hxx the
> SipMessage.hxx file from the ReSiprocate project should be included (which
> it is not) i.e.
> 
>    #include "resiprocate/SipMessage.hxx"
> 
> This is because it refers to the class later on:
>    class SipMessage;
> 
> The above line is not sufficient as the definition of the class is not
> included (hence the #include line at the top).
> 
> Also, a different error is the second constructor of the class
> DialogUsageManager in DialogUsageManager.hxx. i.e.
> 
>       // deprecated interface
>       //DialogUsageManager(std::auto_ptr<SipStack> stack =
> std::auto_ptr<SipStack>(new SipStack(0,0,false)));
> 
> This constructor inserts a declaration in a defintion file, which is wrong
> surely? I'm not too worried about this since the constructor is commented as
> 
> "deprecated". I've just commented out the definition and the implemenmtation
> 
> in the .cxx file and I'll use the other constructor in all cases
> 
> Can anyone confirm these issues?
> 
> Cheers,
> Tony.
> 
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel
>