RE: [reSIProcate] bug in ClientOutOfDialogReg.cxx

[Scott Godin <slgodin@xxxxxxxxxxxx>]

Title: Message

Hi Elizabeth,

 

It definitely is a bug!  I'll commit a fix for this.  Also when looking at this I noticed the ClientOutOfDialogReq is destroyed if you get a 1xx response - I made an additional change so that it will wait for a final response.  I don't have a test for this though - so let me know if there are issues.

 

Thanks,

 

Scott

 

---

From: Elizabeth Clark [mailto:elizabeth.clark@xxxxxxxxxxxxxxxxxxxxxx]
Sent: Thursday, February 03, 2005 1:36 PM
To: resiprocate-devel@xxxxxxxxxxxxxxxxxxx
Subject: [reSIProcate] bug in ClientOutOfDialogReg.cxx

 

I believe this is a bug. The dispatch should be called for 2XX messages.

 

Index: ClientOutOfDialogReq.cxx
===================================================================
--- ClientOutOfDialogReq.cxx    (revision 3844)
+++ ClientOutOfDialogReq.cxx    (working copy)
@@ -40,7 +40,7 @@
 {
        assert(msg.isResponse());
    
-    if (msg.header(h_StatusLine).statusCode() < 200)
+    if (msg.header(h_StatusLine).statusCode() >= 200)
     {
        OutOfDialogHandler *handler = mDum.getOutOfDialogHandler(msg.header(h_CSeq).method());
        if(handler != NULL)

 

 

Elizabeth Clark                                
Bridgewater Systems Corporation               
Phone :  (613) 591-9104 x2776
E-mail : mailto:elizabeth@xxxxxxxxxxxxxxxxxxxxxx