< Previous by Date Date Index Next by Date >
  Thread Index  

[reSIProcate] Tuple IPV6 bug


Hello,

I spotted what appears to be a bug in the IPV6 code in a Tuple constructor 
where the if and else portions are reversed when testing if 
printableAddr.empty().

Jon

Index: sip/resiprocate/os/Tuple.cxx
===================================================================
--- sip/resiprocate/os/Tuple.cxx        (revision 3384)
+++ sip/resiprocate/os/Tuple.cxx        (working copy)
@@ -63,11 +63,11 @@
       m_anonv6.sin6_port = htons(port);
       if (printableAddr.empty())
       {
-         DnsUtil::inet_pton( printableAddr, m_anonv6.sin6_addr);
+         m_anonv6.sin6_addr = in6addr_any;
       }
       else
       {
-         m_anonv6.sin6_addr = in6addr_any;
+         DnsUtil::inet_pton( printableAddr, m_anonv6.sin6_addr);
       }
 #else
          assert(0);