Re: [reSIProcate] Base64Coder class change
Ok - I see what you mean. I went and fixed this stuff.
The Base64Coder::encode and Base64Coder::decode function still exist but I
don't recommend using them. Instead, on the a data object, call base64encode
and abse64decode to get real base64. There is a variant that is safe in URL
(and in our case tokens) that you can get by calling base64encode and
passing a single parameter of true. Note this is not base64 but close to it
and discussed in the RFC. The decode function will decode either.
Given the Base64Coder functions don't encode to base64, and duplicated
function in Data - I would like to remove them. I fixed the two place where
the stack called them to call the Data ones instead.
Cullen
On 9/15/04 1:55 PM, "Jason Fischl" <jason@xxxxxxxxxxxxxx> wrote:
> "+" is a token but "/" and "=" are considered separators so this will not be
> ok. We should probably leave the old implementation as it was and add a new
> interface for "true" base64 encoding/decoding.
>
>
>> -----Original Message-----
>> From: Cullen Jennings [mailto:fluffy@xxxxxxxxx]
>> Sent: Wednesday, September 15, 2004 1:50 PM
>> To: Jason Fischl; ReSiprocate
>> Subject: Re: [reSIProcate] Base64Coder class change
>>
>>
>>
>> Good point - I forgot this generated the via stuff. The new
>> version is going
>> to produce + / and = characters in the output. I don't know if that will
>> cause problems or not.
>>
>> The code is still ugly and I should clean it up.
>>
>>
>> On 9/15/04 1:32 PM, "Jason Fischl" <jason@xxxxxxxxxxxxxx> wrote:
>>
>>> If the algorithm changed, the resip magic cookie should also
>> change since
>>> the via will no longer be decodable if generated by the
>> previous version of
>>> the coder.
>>>
>>>
>>>> -----Original Message-----
>>>> From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>>> [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx]On Behalf Of
>>>> Cullen Jennings
>>>> Sent: Tuesday, September 14, 2004 10:49 PM
>>>> To: ReSiprocate
>>>> Subject: [reSIProcate] Base64Coder class change
>>>>
>>>>
>>>>
>>>> I changed this so it produces Base 64 as specified in RFC is 3548
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> resiprocate-devel mailing list
>>>> resiprocate-devel@xxxxxxxxxxxxxxxxxxx
>>>> https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel
>>>>
>>>
>>>
>>
>>
>>
>
>