Re: [repro-devel] WebAdmin domain
Inline...
> > 5. You've modified the way the admin password is used (I think), so
> > that it is no longer using the admin user from the UserStore. This
> > change is not backward compatible with the old release, and should
be
> > adjusted. Essentially the command line parameter for admin password
> was
> > intended to only be used once, to originally set the password. This
> > would cause the user to be created in the UserStore, then the
command
> > line arg is no longer required, except to change the pwd. One
option
> is
> > to just revert this code to it's old form, but it is nice to be able
> to
> > set/change the password via the web gui. Ideally - changing the
> > password parameter on the web gui causes the admin entry in the
> > userstore to be updated. This gives us the desired functionality
and
> > maintains backwards compatibility.
>
> I think that parameters table is a better place for admin password. We
> can
> move admin password from userStore to parameters table, if we found
> admin
> record in userStore, for backward compatibility
[Scott] Why do you think it's best? I think the Users Tables make more
sense. If in the future we want to have multiple administrators, and/or
be able to flag regular users as administrators - then the Users tables
gives more flexibility.
> > 7. #4 (from email below) is still a backwards compatibility issue
> that
> > needs to be solved before merging with mainline.
>
> May be we need silently move database to new location? If no db files
> present in new location and they are exist in exe directory.
[Scott] Some people (including myself) - are possibly running multiple
copies of repro on the same box. This change will break that. How
about: if not db directory is specified and db exists in working
directory then use it - else use/create db from profile directory.
> >> - It would be good if the parameters page showed the default
> values
> > -
> >> perhaps we should load the parameters table with all of the compile
> >> time
> >> defaults at startup - thought?
> >>
>
> We can not do this at this time. We need rewrite CommandLineParser for
> expose default values, or create new class CommandLineDefault. One of
> this classes will be seen by WebAdmin.
[Scott] I think this is important to solve from a usability standpoint.
We could move the default values into the ReproConfiguration class - The
CommandLineParser class could use these defaults instead of the ones
hardcoded in that class.
> Summary - what I need to do:
> 1) Move db files from exe dir to new location, if db found in old
> location
See comment above.
> 2) Move admin password from UserStore to parameters table if
admin
> record found in userStore.
See comment above.
> 3) Fix the bug in Parameters table when empty editbox not saved.
> 4) See for saving combo box ( comment 11)
> 5) Remove Using.html from distro and add link to web page. Add
> link to http://localhost:5080.
Note: Link to localhost:5080 will only work if web admin is enabled and
web port is set to 5080. You can add a link directly to the wiki using
page.
> 6) Allow users to see default values in parameters web page.
> 7) Any other?