Re: [repro-devel] WebAdmin domain
Hi Ruslan,
I finally got some cycles to start reviewing your changes. Overall
things look great - these are very useful additions to repro! Thanks.
Some preliminary comments/questions:
1. While reviewing the code I made some formatting changes - mainly
revolving around the case used for method and variable names. Some
general rules that are followed in most of the resip code:
- method and local variable names start with a lower case letter
- all if statements contain bracketing on a separate line
- member variables always start with a lower case m followed by an
upper case letter
2. Parameters
- we should remove the domains and routes settings from the parameter
table, there are already separate pages to configure these in repro -
the command line options where just there to be able to start repro
completely from command line without every pre-configuring from the web
interface.
- It would be good if the parameters page showed the default values -
perhaps we should load the parameters table with all of the compile time
defaults at startup - thought?
3. Why is the new Notify log class needed? This may be confusing for
linux implementations.
4. Backwards compatibility - Current repro windows users will likely
have their berkely db files located in the same directory as the binary
- if they upgrade to this release - repro will not use them - we should
probably fix this, so that if the db files are installed in the exe
directory or working directory, then they are used instead of using the
profile path. Or we could just use the profile paths if we are running
as a service??
Thanks,
Scott