Re: [recon-devel] Memory leaks

[Scott Godin <sgodin@xxxxxxxxxxxxxxx>]

Nice catches.  These all look valid to me.  While testing the fix, I found a few more leaks, and it also became apparent that the Sdp copy constructor was not doing a deep copy of the media lines, so I fixed those too.

Thanks for pointing these out.

Scott

On Tue, Jul 7, 2009 at 9:42 PM, Julio Cabezas <jcabezas@xxxxxxxxxxxxx> wrote:

Scott,

 

Could you check, please, if the following points in code are memory leaks ?

 

1)  file Sdp.cxx, 

     function  Sdp::~Sdp(), 

     should call clearMediaLines()

 

2)  file SdpHelperResip.cxx,

     function  createSdpFromResipSdp()

     statement: sdp->addTime(*sdpTime);

     imediately after should write “delete sdpTime;

 

3)  file SdpHelperResip.cxx,

     function  createSdpFromResipSdp()

     statement: mediaLine->addPotentialMediaView(*potentialSdpMediaLine);

     imediately after should write “delete potentialSdpMediaLine; “

 

4)  file SdpHelperResip.cxx,

     function  createSdpFromResipSdp()

     statement: mediaLine->addCodec(*codec);

     imediately after should write “delete codec;”

 

 

Best regards,

Julio Cabezas

 

 

_______________________________________________
recon-devel mailing list
recon-devel@xxxxxxxxxxxxxxx
List Archive: http://list.resiprocate.org/archive/recon-devel/