< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [recon-devel] Crash in authentication


Hi,

 

            Yes, it fixed the issue.  There are no more crashes due to authentication failure.

 

 

> Actually just removing the assert will not work.  I''ve commited a
> different fix to have the ClientAuthManager state cleared out before
> doing a registration retry.  Please let me know if this fixes your
> issue.
> 
> Scott
> 
> On Fri, Jan 16, 2009 at 11:03 AM, Scott Godin <sgodin@xxxxxxxxxxxxxxx> wrote:
> > I traced the code - essentially what is happening is that the iptel
> > server returns a 401 when the password is bad.  We try to register
> > twice (since the nonce is different in each challenge), then give up
> > (RealmAuth state is now Failed).  When the registration retry timer
> > expires, addAuthentication is called on the register message - this
> > registration has the same DialogSetId as the original attempts and
> > ends up triggering the assert in ClientAuthManager line 311:
> > assert(mState != Failed);  I think it makes sense to just remove the
> > offending assert - since the next line will just return and the
> > message will be sent with no auth headers - which is the desired
> > result.
> >
> > I have commited this change to SVN.
> >
> > Scott
> >
> > 2009/1/15 Julio Cabezas <jcabezas@xxxxxxxxxxxxx>:
> >> Hi,
> >>
> >>             Here goes the DEBUG level recon trace.
> >>
> > ...
> > 

 

Thanks,

Julio Cabezas