< Previous by Date Date Index Next by Date >
  Thread Index  

[Msrp] Re: MSRP Project: a quick note about consistency


Derek wrote:

Consistency is good; I would be more inclined to go w/ the resip filename
style as a sipfoundry standard; I like having the filename match the class
name, and having our projects match the conventions of a possible common
library.


I'm okay making the filenames the same as the classes; my main point wasn't that what was already in place is necessarily the One True Way as much as people need to pay attention to what's already been done. If something needs to be changed, it has to be coordinated. But just checking in a bunch of files that are not consistent with the body of work already in the project *will* cause heartburn.

On the other hand, if we're appealing to a cross-sipfoundry convention, the cxx/hxx usage really makes resip the odd man out. In all the code I've ever worked on, only the stuff that has come out of Vovida uses the ?xx suffixes. Unless we think there will be significant problems doing so, I would far prefer to leave the MSRP project using cpp/h suffixes. I'd like to hear others' opinions on this...

/a